feat: confstash — standardized project config loading (discovery, extends/presets, layered merge with provenance) - #97
Merged
Merged
Conversation
…ends/presets, layered merge with provenance)
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
confstashpackage: a cosmiconfig-equivalent, in-house config loader for CLI tools — the project-level complement toappstash. First consumer will be safegres (configurable rules/presets/scoring, constructive-io/constructive-planning#1282); designed so@pgpmjs/env's hand-rolledpgpm.config.js/pgpm.jsonwalkUp+deepmerge loading can later migrate onto it behavior-preservingly (see constructive-io/constructive-planning#1283).Key decisions:
loadSync) so CLIs like pgpm (whose loader is synchronous) can adopt it;load()additionally supports ESM.mjsconfigs via an indirect dynamic import that survives CJS transpilation/jest.arrayMerge: 'replace'default — matches@pgpmjs/env'sreplaceArrayssemantics.extendsresolution: named presets → relative paths → npm packages, recursive with cycle detection;defineConfig<T>()for typed authoring.source/origin;explainLayersattributes each resolved leaf value (likeeslint --print-config+git config --show-origin).userStashlayer reads~/.<tool>/config/config.jsonviaappstash(workspace dep); the pgpm-compat shape is covered by a dedicated test.Tests: 29 passing (
packages/confstash, usesNODE_OPTIONS=--experimental-vm-modulesfor the ESM-config test).Link to Devin session: https://app.devin.ai/sessions/671aac6e50b04e8caacd3f54c1c63bc6
Requested by: @pyramation