Skip to content

ci: post release failures to #bot-patchwave in Slack#53

Merged
blimmer merged 2 commits into
mainfrom
feature/pw-48-failed-deployments-should-post-to-bot-patchwave-in-slack
Jul 8, 2026
Merged

ci: post release failures to #bot-patchwave in Slack#53
blimmer merged 2 commits into
mainfrom
feature/pw-48-failed-deployments-should-post-to-bot-patchwave-in-slack

Conversation

@blimmer

@blimmer blimmer commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

The release workflow was silent on failure. The 0.7.0 release failed Apple notarization on two attempts — a 403 FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED (an expired Apple Developer agreement, which needs a human to re-accept) — and nobody was alerted until a user hit the stale patchwave.ai/analyze.sh installer and reported the 404. This adds a notify-failure job that assumes the release role via OIDC and publishes an AWS Chatbot custom notification to the shared cb-notifications-bot-patchwave SNS topic whenever the pipeline fails (including the test gate). Closes PW-48.

Depends on contextbridge/patchwave#90, which grants the release role sns:Publish on that topic — deploy that first, or the publish call will be denied.

Review focus

  • The job derives the AWS account from sts get-caller-identity and builds the topic ARN from the stable cb-notifications-bot-patchwave name, so no account id is hard-coded in the workflow. Preferable to a hard-coded ARN or a new secret, I think — but open to either.
  • if: ${{ failure() }} with needs: [test, release] fires on any pipeline failure but deliberately not on cancellation. It also fires per failed run/attempt, which is the intent — silence was the whole bug.
  • Least privilege: the job requests only id-token: write and uses configure-aws-credentials directly (not the fetch-release-secrets composite), so the alert path doesn't depend on the signing-secret reads that can themselves fail.

Commits

  • 658bfbb — ci: post release failures to #bot-patchwave in Slack

Adds a notify-failure job to the release workflow that assumes the release role
via OIDC and publishes an AWS Chatbot custom notification to the shared
cb-notifications-bot-patchwave SNS topic whenever the pipeline fails. A failed
release (e.g. an expired Apple notarization agreement) previously stayed silent
until someone hit the stale installer.
@blimmer
blimmer requested a review from jcarver989 as a code owner July 8, 2026 14:02
@blimmer
blimmer merged commit 979543d into main Jul 8, 2026
8 checks passed
@blimmer
blimmer deleted the feature/pw-48-failed-deployments-should-post-to-bot-patchwave-in-slack branch July 8, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants