ci: post release failures to #bot-patchwave in Slack#53
Merged
blimmer merged 2 commits intoJul 8, 2026
Merged
Conversation
Adds a notify-failure job to the release workflow that assumes the release role via OIDC and publishes an AWS Chatbot custom notification to the shared cb-notifications-bot-patchwave SNS topic whenever the pipeline fails. A failed release (e.g. an expired Apple notarization agreement) previously stayed silent until someone hit the stale installer.
…-to-bot-patchwave-in-slack
jcarver989
approved these changes
Jul 8, 2026
blimmer
deleted the
feature/pw-48-failed-deployments-should-post-to-bot-patchwave-in-slack
branch
July 8, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow was silent on failure. The 0.7.0 release failed Apple notarization on two attempts — a
403 FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED(an expired Apple Developer agreement, which needs a human to re-accept) — and nobody was alerted until a user hit the stalepatchwave.ai/analyze.shinstaller and reported the 404. This adds anotify-failurejob that assumes the release role via OIDC and publishes an AWS Chatbot custom notification to the sharedcb-notifications-bot-patchwaveSNS topic whenever the pipeline fails (including thetestgate). Closes PW-48.Depends on contextbridge/patchwave#90, which grants the release role
sns:Publishon that topic — deploy that first, or the publish call will be denied.Review focus
sts get-caller-identityand builds the topic ARN from the stablecb-notifications-bot-patchwavename, so no account id is hard-coded in the workflow. Preferable to a hard-coded ARN or a new secret, I think — but open to either.if: ${{ failure() }}withneeds: [test, release]fires on any pipeline failure but deliberately not on cancellation. It also fires per failed run/attempt, which is the intent — silence was the whole bug.id-token: writeand usesconfigure-aws-credentialsdirectly (not thefetch-release-secretscomposite), so the alert path doesn't depend on the signing-secret reads that can themselves fail.Commits
658bfbb— ci: post release failures to #bot-patchwave in Slack