Skip to content

⚡ Bolt: [O(1) label deduplication] - #61

Open
coredipper wants to merge 1 commit into
mainfrom
bolt/perf-O1-deduplication-16863514154974805901
Open

⚡ Bolt: [O(1) label deduplication]#61
coredipper wants to merge 1 commit into
mainfrom
bolt/perf-O1-deduplication-16863514154974805901

Conversation

@coredipper

Copy link
Copy Markdown
Owner

💡 What: Replace list-based deduplication (if item not in seen: seen.append(item)) with dict.fromkeys for footnote labels.
🎯 Why: Searching a list for membership is an $O(N)$ operation, causing the marker extraction process to be $O(N^2)$ based on the number of markers in the text.
📊 Impact: Changes deduplication from $O(N^2)$ to $O(N)$ for parsing footnotes in page bodies, improving parse speed for large files.
🔬 Measurement: Observe lower cpu usage during marker deduplication in files with heavily footnoted bodies.


PR created automatically by Jules for task 16863514154974805901 started by @coredipper

Co-authored-by: coredipper <1830173+coredipper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant