Add --disable_watches flag

[miekg]

Setting this flag to true makes fleet not set any watches in etcd.

[miekg]

Ah, yeah.

1. Haven't added prometheus dependency in GodepsForgot to add a file.
2. ./test works. Hasn't seen any production use.

Not putting this neatly in my go path is biting me.

[jonboulle]

@miekg we'd like to clean this up and get it merged. What's the reason you removed the jitter stuff?

[miekg]

[ Quoting notifications@github.com in "Re: [fleet] Add --disable_watches f..." ]

@miekg we'd like to clean this up and get it merged. What's the reason you removed the jitter stuff?

failing tests... I couldn't (quickly) find wth was happening there.

[jonboulle]

Hmm, ok - do you want to squash these commits and we can land as-is then?

[jonboulle]

and tweak the commit message :-)

[miekg]

done.

[jonboulle]

Er, sorry. I thought I commented here but apparently not. Can you remove lines 36-46 from this file?

[miekg]

lines 36-46 removed.

[jonboulle]

@miekg thanks for your patience :-)

[anwald]

If changes to schedule state in etcd are the stimulus for fleetd agent to reconcile what needs to be done locally, then what stimulus remains after --disable_watches is enabled? You say that latency increases, but what stimuli remain? Does fleetd also put the agent under some timer? Thanks.

[jonboulle]

There is a periodic timer that wakes up the agent every 5 seconds to do
this reconciliation.

On 7 November 2016 at 09:50, Andrew Wald notifications@github.com wrote:

If changes to schedule state in etcd are the stimulus for fleetd agent to
reconcile what needs to be done locally, then what stimulus remains after
--disable_watches is enabled? You say that latency increases, but what
stimuli remain? Does fleetd also put the agent under some timer? Thanks.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1406 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACewN1t8ryPh5gwN5GjYrPu4Fotd7lLVks5q7uZOgaJpZM4HJnaT
.