Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

metrics: added prometheus metrics for fleet - #1524

Merged
tixxdz merged 3 commits into
coreos:masterfrom
endocode:kayrus/metrics
Apr 18, 2016
Merged

metrics: added prometheus metrics for fleet#1524
tixxdz merged 3 commits into
coreos:masterfrom
endocode:kayrus/metrics

Conversation

@kayrus

@kayrus kayrus commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

@miekg I've rebased your old PR #1415 and updated godeps

@kayrus kayrus self-assigned this Mar 31, 2016
@kayrus kayrus added this to the v0.13.0 milestone Mar 31, 2016
@kayrus

kayrus commented Mar 31, 2016

Copy link
Copy Markdown
Contributor Author

@joshix could you review docs?

@robszumski

Copy link
Copy Markdown
Contributor

LGTM, but defer to @joshix

@joshix

joshix commented Apr 1, 2016

Copy link
Copy Markdown
Contributor

LGTM for purpose.

Defer on merging due to the godeps update. @kayrus and/or fleet team, PTBF

@joshix

joshix commented Apr 1, 2016

Copy link
Copy Markdown
Contributor

Supersedes #1415

@hectorj2f

Copy link
Copy Markdown
Contributor

Nice 😉

@kayrus

kayrus commented Apr 4, 2016

Copy link
Copy Markdown
Contributor Author

@jonboulle this PR is ready to be merged. I don't think tests are necessary for this functionality. At least I didn't find any metrics tests in etcd.

@miekg

miekg commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

[ Quoting notifications@github.com in "Re: [coreos/fleet] metrics: added p..." ]

@jonboulle this PR is ready to be merged. I don't think tests are necessary for this functionality. At least I didn't find any metrics tests in etcd.

Testing this is pretty annoying, would be nice if prometheus would provide some
kind of metrics recorder that would make this easier...

@jonboulle

Copy link
Copy Markdown
Contributor

LGTM but let's get v0.12.0 done first?

@tixxdz

tixxdz commented Apr 5, 2016

Copy link
Copy Markdown
Contributor

@jonboulle as discussed all v0.12.0 PRs and Issues have been handled!

@kayrus

kayrus commented Apr 18, 2016

Copy link
Copy Markdown
Contributor Author

Blocks #1537

@tixxdz

tixxdz commented Apr 18, 2016

Copy link
Copy Markdown
Contributor

Thanks all, this one was reviewed and already has lgtm! and it touches lot of parts of the code where other PRs may conflict with it. So merging this one and #1537 will be on top later when it's ready and reviewed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants