This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: introduce an option --max-print-units - #1664
Closed
dongsupark wants to merge 3 commits into
Closed
Conversation
dongsupark
force-pushed
the
master
branch
7 times, most recently
from
August 23, 2016 11:00
3b60e93 to
875d938
Compare
added 2 commits
August 26, 2016 10:37
For users who want to limit number of units to be printed, introduce an option "--max-print-units" for these commands: destroy, unload, stop, list-unit-files, and list-units. Note that the default value of --max-print-units should be 0, which means "all units are printed", so that the default behavior should remain as before. Fixes coreos#1593
Allow Cluster.WaitForN{UnitFiles,Units,ActiveUnits} to accept opts, an
optional string that contains parameters to be passed to fleetctl.
As it's supposed to be optional, we don't need to modify call sites
of those functions: no opts for WaitFor*() means no opts for
nc.Fleetctl().
It's a preparation for a new test that is supposed to pass
"--max-print-units" option to the fleetctl command.
dongsupark
force-pushed
the
dongsu/fleetctl-max-print-units
branch
4 times, most recently
from
August 26, 2016 09:48
0ee5d23 to
7a43073
Compare
TestMaxPrintUnits checks if the "--max-print-units" option works correctly for commands like destroy, unload, stop, list-unit-files, and list-units.
dongsupark
force-pushed
the
dongsu/fleetctl-max-print-units
branch
from
August 26, 2016 10:08
7a43073 to
8b3b501
Compare
dongsupark
force-pushed
the
master
branch
2 times, most recently
from
August 30, 2016 12:26
bdc94e8 to
fa5aa3a
Compare
Contributor
|
NACK, why bake this into fleet? This doesn't affect performance or anything, so can't people just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users who want to limit number of units to be printed, introduce an option
"--max-print-units"for these commands: destroy, unload, stop, list-unit-files, and list-units.Note that the default value of
--max-print-unitsshould be 0, which means"all units are printed", so that the default behavior should remain as before.Fixes #1593
/cc @kayrus