Fix #70: don't measure comment contents in inheriting templates#116
Open
PetrDlouhy wants to merge 1 commit into
Open
Fix #70: don't measure comment contents in inheriting templates#116PetrDlouhy wants to merge 1 commit into
PetrDlouhy wants to merge 1 commit into
Conversation
…ates
In a template that {% extends %} another, a {% comment %} opener
placed outside of any {% block %} was skipped by the
'extends and not inblock' continue before the comment flag was set.
Variable tokens inside the comment were then recorded as executable
lines, and reported as missing forever - they can never run.
Set the comment flag before the extends-skip, mirroring how
{% endcomment %} is already handled earlier in the loop.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
{% comment %}part of #70 — for comments in inheriting templates it is not a missing "ignore" feature, it is a measurement bug.In a template that
{% extends %}another, a{% comment %}opener placed outside of any{% block %}is skipped by theextends and not inblockcontinue beforecomment = Trueis set. Variable tokens inside the comment are then recorded as executable lines and reported as missing forever — they can never run. (Plain text inside the comment happens to be saved by the text branch's own extends-guard, which is why the symptom only shows when the comment contains{{ vars }}or tags.)Minimal repro:
The fix sets the comment flag before the extends-skip, mirroring how
{% endcomment %}is already handled earlier in the loop. Includes a regression test; the full test suite passes.🤖 Generated with Claude Code