Re-enable client transport-error-injection test on an io_context#37
Open
mvandeberg wants to merge 1 commit into
Open
Re-enable client transport-error-injection test on an io_context#37mvandeberg wants to merge 1 commit into
mvandeberg wants to merge 1 commit into
Conversation
|
An automated preview of the documentation is available at https://37.burl.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-07-22 18:33:07 UTC |
Re-enable client_test::testTransportErrorInjection (previously commented out). burl's connect path wraps corosio::timeout, which needs an io_context-backed executor, so drive each fuse injection round with a local runner passed to fuse::armed(run_one, fn): it runs the round on a corosio::io_context and returns the round's exception (null on success) without rethrowing (armed rethrows it from its own synchronous code). Guard the body out on GCC affected by PR124584 (miscompiles tuple-protocol structured bindings captured in a coroutine frame): skip on GCC 15.0-15.3 and all 16.x, since version macros cannot distinguish a patched 16.x from an unpatched one. Runs on clang, GCC 14, GCC 15.4+, and GCC 17+.
mvandeberg
force-pushed
the
pr/reenable-transport-error-test
branch
from
July 23, 2026 18:06
f26b1cc to
d0b1047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable client_test::testTransportErrorInjection (previously commented out). burl's connect path wraps corosio::timeout, which needs an io_context-backed executor, so drive each fuse injection round with a local runner passed to fuse::armed(run_one, fn): it runs the round on a corosio::io_context and returns the round's exception (null on success) without rethrowing (armed rethrows it from its own synchronous code).
Guard the body out on GCC affected by PR124584 (miscompiles tuple-protocol structured bindings captured in a coroutine frame): skip on GCC 15.0-15.3 and all 16.x, since version macros cannot distinguish a patched 16.x from an unpatched one. Runs on clang, GCC 14, GCC 15.4+, and GCC 17+.
CI will pass after #36 is mergedNow requires #38