Skip to content

fix(any_write_sink): accept mutable buffer sequences in write#370

Merged
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:fix/any-write-sink-mutable-write
Jul 23, 2026
Merged

fix(any_write_sink): accept mutable buffer sequences in write#370
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:fix/any-write-sink-mutable-write

Conversation

@sgerbino

Copy link
Copy Markdown
Collaborator

ConstBufferSequence admits mutable sequences, but write windowed them through buffer_param, whose span<mutable_buffer> cannot convert to the type-erased write_(span<const_buffer const>), so calls such as write(make_buffer(some_string)) failed to instantiate. Use const_buffer_param, as write_eof already does.

ConstBufferSequence admits mutable sequences, but write windowed them
through buffer_param, whose span<mutable_buffer> cannot convert to
the type-erased write_(span<const_buffer const>), so calls such as
write(make_buffer(some_string)) failed to instantiate. Use
const_buffer_param, as write_eof already does.
@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://370.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-07-23 13:58:56 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://370.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://370.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://370.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-07-23 14:15:44 UTC

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.36%. Comparing base (49b2db9) to head (c33f2f6).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #370      +/-   ##
===========================================
+ Coverage    98.18%   98.36%   +0.18%     
===========================================
  Files          152      152              
  Lines         8246     8260      +14     
===========================================
+ Hits          8096     8125      +29     
+ Misses         150      135      -15     
Flag Coverage Δ
linux 98.39% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/boost/capy/io/any_write_sink.hpp 98.09% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b2db9...c33f2f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgerbino
sgerbino merged commit 4884c0d into cppalliance:develop Jul 23, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Beast2 Jul 23, 2026
@sgerbino
sgerbino deleted the fix/any-write-sink-mutable-write branch July 23, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants