Skip to content

Fix signed negation in add/sub operators causing UBSAN to flag operation #429

Merged
mborland merged 6 commits into
developfrom
ubsan
Jul 22, 2026
Merged

Fix signed negation in add/sub operators causing UBSAN to flag operation #429
mborland merged 6 commits into
developfrom
ubsan

Conversation

@mborland

Copy link
Copy Markdown
Member

Closes: #427

@mborland mborland added Bug Something isn't working Boost Review Feedback from the review period including pre- and post- on the ML labels Jul 22, 2026
@cppalliance-bot

cppalliance-bot commented Jul 22, 2026

Copy link
Copy Markdown

An automated preview of the documentation is available at https://429.int128.prtest3.cppalliance.org/libs/int128/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-07-22 21:00:08 UTC

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.24%. Comparing base (98b3848) to head (aff381a).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #429      +/-   ##
===========================================
+ Coverage    96.21%   96.24%   +0.02%     
===========================================
  Files           79       81       +2     
  Lines         7063     7103      +40     
  Branches      2450     2468      +18     
===========================================
+ Hits          6796     6836      +40     
  Misses          31       31              
  Partials       236      236              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland
mborland merged commit 4926998 into develop Jul 22, 2026
83 checks passed
@mborland
mborland deleted the ubsan branch July 22, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Boost Review Feedback from the review period including pre- and post- on the ML Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[review][bug] Negation caught by UBSAN where it shouldn't be

2 participants