cleaned up signal handler and improved stack trace generation#5581
Merged
Conversation
Collaborator
Author
|
This needs actual unit tests for the stack trace code. I have been meaning to do this for quite a while since they different in format between Windows and Linux. Also to leverage them in daca instead of calling |
firewave
force-pushed
the
stack
branch
5 times, most recently
from
January 5, 2024 16:17
3fc8c18 to
80d4aa7
Compare
Collaborator
Author
|
This omits all frames above our own code now without adjusting the frame number: I guess I will make this behavior optional in case the code needs to show all frames in the future. |
firewave
force-pushed
the
stack
branch
4 times, most recently
from
January 6, 2024 15:24
0e21bd6 to
533669b
Compare
…made it re-usable
…ed stacktrace generation
firewave
marked this pull request as ready for review
February 20, 2024 13:26
danmar
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5540 (review) for related discussion.