Fix #14894: false positive: co_return not recognized as return in combination with {} #8741
Open
ludviggunne wants to merge 2 commits into
Open
Fix #14894: false positive: co_return not recognized as return in combination with {} #8741ludviggunne wants to merge 2 commits into
ludviggunne wants to merge 2 commits into
Conversation
| if (out) | ||
| *out = loopEnds.back(); | ||
| } else if (Token::Match(tok, "return|throw")) { | ||
| } else if (Token::Match(tok, "return|co_return|throw")) { |
Collaborator
There was a problem hiding this comment.
This will probably crop up in multiple places, so we might want to add a helper function, which should also check language and standard.
Collaborator
Author
There was a problem hiding this comment.
I'm not sure where I would put it. A method of Token maybe?
Collaborator
There was a problem hiding this comment.
Or put it in our dumping ground, astutils.cpp. E.g. isUnevaluated() also lives there.
ludviggunne
force-pushed
the
14894-co_return-braces
branch
from
July 21, 2026 13:27
7a50aff to
09d75c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.