Skip to content

ENG-783 - A ticket's key has one name - #137

Merged
czpython merged 1 commit into
mainfrom
eng-783-ticket-key-one-name
Jul 28, 2026
Merged

ENG-783 - A ticket's key has one name#137
czpython merged 1 commit into
mainfrom
eng-783-ticket-key-one-name

Conversation

@czpython

@czpython czpython commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Residue after #129: the column, both wire responses, and every frontend consumer
say ticket_key. Two places still said ref, carrying the same value.

TicketCell took ticketRef?: string | null plus a required fallback, and
ended on {ticketRef ?? fallback}. Its one caller passes wi.ticketKey, which is
a required string backed by a non-null column — so the optionality, the ??
tail, and fallback itself were unreachable. The prop is now ticketKey: string
and the dead path is gone.

Build's input carried three ticket fields. ticket_title and ticket_url
were write-only: dispatch set them, run_multistep declared them, and nothing
read them — BuildPromptContext has no title field, no template names either, and
the only reads repo-wide were two assertions pinning the wiring. ticket_ref was
read, but dispatch assigned it item.ticket_key unchanged and the workflow
already holds the row. All three are off the input; the prompt context renders
ticket_ref from self.subject.ticket_key.

BuildPromptContext.ticket_ref and the templates are unchanged — that field is
the prompt-facing reference, and it now reads the row instead of a frozen copy.

Renaming ticket_refticket_key on the input was the obvious fix and the
wrong one: it buys one canonical spelling and leaves the input still carrying
ticket fields, so the next spelling question costs another drain. Removing the
fields settles it.

@czpython
czpython force-pushed the eng-783-ticket-key-one-name branch from d0c65e7 to ff4488b Compare July 28, 2026 06:02
@czpython
czpython enabled auto-merge (squash) July 28, 2026 06:03
@czpython
czpython merged commit d808727 into main Jul 28, 2026
2 checks passed
@czpython
czpython deleted the eng-783-ticket-key-one-name branch July 28, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant