ENG-783 - A ticket's key has one name - #137
Merged
Merged
Conversation
czpython
force-pushed
the
eng-783-ticket-key-one-name
branch
from
July 28, 2026 06:02
d0c65e7 to
ff4488b
Compare
czpython
enabled auto-merge (squash)
July 28, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Residue after #129: the column, both wire responses, and every frontend consumer
say
ticket_key. Two places still saidref, carrying the same value.TicketCelltookticketRef?: string | nullplus a requiredfallback, andended on
{ticketRef ?? fallback}. Its one caller passeswi.ticketKey, which isa required
stringbacked by a non-null column — so the optionality, the??tail, and
fallbackitself were unreachable. The prop is nowticketKey: stringand the dead path is gone.
Build's input carried three ticket fields.ticket_titleandticket_urlwere write-only: dispatch set them,
run_multistepdeclared them, and nothingread them —
BuildPromptContexthas no title field, no template names either, andthe only reads repo-wide were two assertions pinning the wiring.
ticket_refwasread, but dispatch assigned it
item.ticket_keyunchanged and the workflowalready holds the row. All three are off the input; the prompt context renders
ticket_reffromself.subject.ticket_key.BuildPromptContext.ticket_refand the templates are unchanged — that field isthe prompt-facing reference, and it now reads the row instead of a frozen copy.
Renaming
ticket_ref→ticket_keyon the input was the obvious fix and thewrong one: it buys one canonical spelling and leaves the input still carrying
ticket fields, so the next spelling question costs another drain. Removing the
fields settles it.