Clarify retry status-code matching doesn't apply to bulk subscribe RETRY - #5273
Merged
Conversation
…be RETRY matching.httpStatusCodes/gRPCStatusCodes filter on the transport-level status code of the call, but a bulk subscribe handler's per-entry RETRY status isn't carried as an HTTP or gRPC status code, so it's always retried regardless of the configured matching filter. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5273.westus2.7.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5273.westus2.7.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matching.httpStatusCodes/matching.gRPCStatusCodesonly filter on the transport-level status code of the call to the application.RETRYstatus is returned in the response body, not as an HTTP/gRPC status code, so it is not affected bymatchingand is always retried per the policy'sduration/maxRetries/backoff.Test plan
pkg/resiliency/policy.go,pkg/runtime/subscription/bulkresiliency.go,pkg/runtime/subscription/postman/http/http.go,pkg/runtime/subscription/postman/grpc/grpc.go): thematchingfilter only fires when the error is aresiliency.CodeError, and bulk subscribe's per-entryRETRYnever produces one.🤖 Generated with Claude Code