Add TRANSACTION_ISOLATION_LEVEL config in cloudsql-postgres and cloudsql-mysql plugins for develop#675
Merged
vikasrathee-cs merged 1 commit intoJul 20, 2026
Conversation
![gemini-code-assist[bot]](https://cdn.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the 'Transaction Isolation Level' configuration option for CloudSQL MySQL and CloudSQL PostgreSQL plugins, updating their batch sinks, batch sources, connectors, and documentation. The review feedback highlights several improvement opportunities, including changing the visibility of the new configuration field in CloudSQLMySQLSource from public to private for better encapsulation, removing redundant lines, correcting typos (such as 'databse'), and ensuring consistent colon usage in the documentation files.
Comment on lines
+45
to
+46
| **Transaction Isolation Level:** Transaction isolation level for queries run by this sink. | ||
| **Transaction Isolation Level** The transaction isolation level of the database connection |
There was a problem hiding this comment.
These two lines are redundant and contain a missing colon. They can be merged into a single, clean description.
Suggested change
| **Transaction Isolation Level:** Transaction isolation level for queries run by this sink. | |
| **Transaction Isolation Level** The transaction isolation level of the database connection | |
| **Transaction Isolation Level:** The transaction isolation level of the database connection. |
Comment on lines
+45
to
+46
| **Transaction Isolation Level:** Transaction isolation level for queries run by this sink. | ||
| **Transaction Isolation Level** The transaction isolation level of the databse connection |
There was a problem hiding this comment.
These two lines are redundant and contain a typo ('databse' instead of 'database'). They can be merged into a single, clean description.
Suggested change
| **Transaction Isolation Level:** Transaction isolation level for queries run by this sink. | |
| **Transaction Isolation Level** The transaction isolation level of the databse connection | |
| **Transaction Isolation Level:** The transaction isolation level of the database connection. |
vedanshugarg04
force-pushed
the
transaction-isolation-level-develop
branch
from
June 29, 2026 12:41
bfd80f6 to
552c462
Compare
vikasrathee-cs
marked this pull request as ready for review
June 29, 2026 12:53
vishwasvaidya-cloudsufi
force-pushed
the
transaction-isolation-level-develop
branch
from
July 13, 2026 05:51
f2b9fd4 to
a812a14
Compare
…sql-mysql plugins for develop fix: updated widget and docs fix: typos Added a constant for default isolation level
vishwasvaidya-cloudsufi
force-pushed
the
transaction-isolation-level-develop
branch
from
July 13, 2026 05:53
a812a14 to
cf3e095
Compare
shruthi713
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TRANSACTION_ISOLATION_LEVEL config in cloudsql-postgres and cloudsql-mysql plugins