Feature/dss10 api evaluate recipe creation#162
Merged
Conversation
|
This pull request has been linked to Clubhouse Story #58502: Python API client for evaluate recipe creation. |
lpenet
requested changes
Aug 13, 2021
lpenet
left a comment
lpenet
left a comment
Contributor
There was a problem hiding this comment.
Some little changes to make
FChataigner
requested changes
Sep 1, 2021
Contributor
|
LGTM! Will validate it when backend part is fully implemented and tested. |
Contributor
|
@instanceofme does not really add new entries to the API, rather extend existing ones. But nonetheless requesting your insight. |
instanceofme
reviewed
Sep 9, 2021
This reverts commit ee76fc3.
Co-authored-by: Adrien Lavoillotte <adrien.lavoillotte@dataiku.com>
instanceofme
approved these changes
Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ch58502]
Companion backend PR: https://github.com/dataiku/dip/pull/13216