Invoke-DbaDbLogShipping incorrect custom job names for copy and restore jobs

[Shanjohn]

Before submitting a bug report:

• [* ] Ensure you are able to reproduce it on the latest released version (we release often)
• [* ] Verified this bug is not already reported in an issue
• [* ] Verified errors are not related to permissions
• [* ] Can reproduce in a clean PowerShell session (clean = powershell -NoProfile)

Steps to Reproduce

    $LS_DataLocation = "A:\MSSQL\Data"
    $LS_LogLocation = "B:\MSSQL\Logs"
    $BackupSourceLocation = "C:\MSSQL\Backups\LS"
    $BackupSourceShare = "\\someserver\Backups\LS"
    $BackupDestinationLocation = "\\someotherserver\Backups\LS" 

    $params = @{
        SourceSqlInstance = 'sql01'
        DestinationSqlInstance = 'sql02'
        Database = "TestDB"
        BackupNetworkPath = $BackupSourceShare
        BackupLocalPath = $BackupSourceLocation
        BackupScheduleFrequencyType = 'daily'
        BackupScheduleFrequencyInterval = 1
        CopyScheduleFrequencyType = 'daily'
        CopyScheduleFrequencyInterval = 1
        CopyJob = "SomeCopyJob_"
        GenerateFullBackup = $true
        RestoreDataFolder = $LS_DataLocation
        RestoreLogFolder = $LS_LogLocation
        RestoreScheduleFrequencyType = 'daily'
        RestoreScheduleFrequencyInterval = 1
        CopyDestinationFolder = $BackupDestinationLocation
    	NoInitialization = $false
        Standby = $true
        Force = $true
	WhatIf = $true
    	Verbose = $true
    }
    Invoke-DbaDbLogShipping @params

Expected Behavior

VERBOSE: [21:39:41][Invoke-DbaDbLogShipping] Copy job name set to SomeCopyJob_sql01_TestDb
...
VERBOSE: [21:39:41][Invoke-DbaDbLogShipping] Restore job name set to LSRestore_sql01_TestDb

Actual Behavior

VERBOSE: [21:39:41][Invoke-DbaDbLogShipping] Copy job name set to TestDb
...
VERBOSE: [21:39:41][Invoke-DbaDbLogShipping] Restore job name set to LSRestore_TestDb

Environmental data

• PowerShell:
  PSVersion 5.1.14409.1005
  PSEdition Desktop
  PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
  BuildVersion 10.0.14409.1005
  CLRVersion 4.0.30319.42000
  WSManStackVersion 3.0
  PSRemotingProtocolVersion 2.3
  SerializationVersion 1.1.0.1

• SQL Server:
  Microsoft SQL Server 2008 (SP4-GDR) (KB4057114) - 10.0.6556.0 (X64) Dec 28 2017 15:21:01 Copyright (c) 1988-2008 Microsoft Corporation Standard Edition (64-bit) on Windows NT 6.3 (Build 9600: )

[Shanjohn]

This happens because of incorrect string concatenation in https://github.com/sqlcollaborative/dbatools/blob/22c6e7b7855cc68ca662ba04cef09cac6d331531/functions/Invoke-DbaDbLogShipping.ps1#L1358
https://github.com/sqlcollaborative/dbatools/blob/22c6e7b7855cc68ca662ba04cef09cac6d331531/functions/Invoke-DbaDbLogShipping.ps1#L1360
https://github.com/sqlcollaborative/dbatools/blob/22c6e7b7855cc68ca662ba04cef09cac6d331531/functions/Invoke-DbaDbLogShipping.ps1#L1393
https://github.com/sqlcollaborative/dbatools/blob/22c6e7b7855cc68ca662ba04cef09cac6d331531/functions/Invoke-DbaDbLogShipping.ps1#L1395
E.g. this statement "$RestoreJob_$SourceServerName_$($db.Name)" is trying to use $RestoreJob_ and $SourceServerName_ instead of $RestoreJob and $SourceServerName

[sanderstad]

I fixed the code and created a pull request for it. It will be tested and within a short time will be added to production release when everything is approved.