I believe we have both been using black for formatting Python source code, and mostly sticking to pep 8. For now, the JS source code is mostly fairly self-consistent.
Would it make sense to adopt a consistent code style through reformatters and CI tests? It'd help outside contributors make pull requests that are visually similar to the current codebase. I suggest:
- prettier for the JS, following dash-core-components. See this PR.
- black and flake8 for the Python side and the docs, since they're (becoming) the de-facto standard.
- enforcing consistency as part of the CI pipeline.
The timing around this needs to be somewhat well thought through to avoid merge conflicts with existing PRs.
Any thoughts?
I believe we have both been using black for formatting Python source code, and mostly sticking to pep 8. For now, the JS source code is mostly fairly self-consistent.
Would it make sense to adopt a consistent code style through reformatters and CI tests? It'd help outside contributors make pull requests that are visually similar to the current codebase. I suggest:
The timing around this needs to be somewhat well thought through to avoid merge conflicts with existing PRs.
Any thoughts?