fix(node): stop http2 file reads on stream close#36061
Open
nathanwhit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
respondWithFile()andrespondWithFD()read loops when their HTTP/2 stream closes or a write failsrespondWithFile()while preserving caller ownership forrespondWithFD()Motivation
The JavaScript file-response loop chained each
fs.read()through the previous stream write callback without checking the stream lifecycle or callback error. A closed stream could therefore continue scheduling reads. The cleanup path now stops the loop immediately and applies the appropriate descriptor ownership rule.Validation
./tools/format.jscargo build --bin denocargo test -p unit_node_tests --test unit_node -- http2_testcargo test -p node_compat_tests --test node_compat test-http2-respond -- --nocapture(22 tests)