[Bug]: Argo-cd installation fails due to withdrawn github release

[max06]

Feature id and version

ghcr.io/devcontainers-extra/features/argo-cd:1

Dev Container base Image

mcr.microsoft.com/devcontainers/python:1-3-bookworm

What happened?

The latest argo-cd release is 3.0.6
This install script thinks the latest version is 3.0.9
The resulting download url returns a 404.
The download is not checked!
The resulting file contains "Not found" instead of the desired binary.
The install script does not fail, but it should.

There are probably more packages with the same issue.

Relevant log output

ARGOCD_VERSION=3.0.9
Done!

[koralowiec]

Hi!

Yeah, something is wrong with the feature. i was able to run devcontainer with this devcontainer.json:

{
	"name": "Dummy",
	"image": "mcr.microsoft.com/devcontainers/python:1-3-bookworm",
	"features": {
		"ghcr.io/devcontainers-extra/features/argo-cd:1": {}
	}
}

But the argocd command is not working:

I'm going to check it out

[koralowiec]

The argocd feature were using an old custom script to install the tool from GitHub Releases. Within the script it was checking the version based on the tags. The issue was caused by the fact that there was a tag for 3.0.9 version, but no release for it.

I updated the installation script to use nanolayer + gh-release feature, which is the typical way of installing tools from GitHub Release: #138

Once the new version of the feature (1.1.0) is released (via this workflow run), please try it out, and confirm if it's working for you

[max06]

Thanks for the quick reaction!

I can't test this at the moment due to some long running processes in my devcontainer - might take 2-3 days for me to get to that.

[koralowiec]

Hey, it seems the problem is fixed, it's possible to use the tool installed with the feature:

I'm closing this issue, if the problem still exists for you, please reopen it