Need to make sure that namespace temination will not be blocked by the DevWorkspace finalizers

[ibuziuk]

This scenario is particularly important for the Developer Sandbox / workspaces.openshift.com user deactivation flow. When a user is deactivated their namespace is removed. We need to make sure that DevWorkspace presence will not block the namespace removal and it will not be in the Terminating state forever due to finalizers:

[amisevsk]

Tested deleting a few namespaces with various numbers of Workspaces both stopped and running and found no issues. Closing for now as there's not much more to be done.

[Dave-c-Ross]

Still happening :/

  conditions:
  - lastTransitionTime: "2023-10-24T02:23:06Z"
    message: All resources successfully discovered
    reason: ResourcesDiscovered
    status: "False"
    type: NamespaceDeletionDiscoveryFailure
  - lastTransitionTime: "2023-10-24T02:23:06Z"
    message: All legacy kube types successfully parsed
    reason: ParsedGroupVersions
    status: "False"
    type: NamespaceDeletionGroupVersionParsingFailure
  - lastTransitionTime: "2023-10-24T02:23:06Z"
    message: All content successfully deleted, may be waiting on finalization
    reason: ContentDeleted
    status: "False"
    type: NamespaceDeletionContentFailure
  - lastTransitionTime: "2023-10-24T02:23:06Z"
    message: 'Some resources are remaining: devworkspaceroutings.controller.devfile.io
      has 3 resource instances'
    reason: SomeResourcesRemain
    status: "True"
    type: NamespaceContentRemaining
  - lastTransitionTime: "2023-10-24T02:23:06Z"
    message: 'Some content in the namespace has finalizers remaining: devworkspacerouting.controller.devfile.io
      in 3 resource instances'
    reason: SomeFinalizersRemain
    status: "True"
    type: NamespaceFinalizersRemaining
  phase: Terminating

There is a finalizer devworkspacerouting.controller.devfile.io that seems to get stuck there. I manually removed it

apiVersion: controller.devfile.io/v1alpha1
kind: DevWorkspaceRouting
metadata:
  annotations:
    controller.devfile.io/devworkspace-started: "false"
  creationTimestamp: "2023-09-26T13:43:25Z"
  deletionGracePeriodSeconds: 0
  deletionTimestamp: "2023-10-24T02:05:41Z"
  finalizers:
  - devworkspacerouting.controller.devfile.io

[amisevsk]

I believe that finalizer is being set by the Che Operator to ensure routing configurations for the workspace are properly cleaned up in the gateway container. I'll reopen the issue so that we can look into it.

To double check, @Dave-c-Ross is the finalizer stuck for a long period (e.g. 5+ minutes)? Is the Che Operator healthy on that cluster? We might expect some delay in clearing that finalizer but it shouldn't indefinitely block namespace removal.