Sprint 15: close-the-roadmap — macOS gmp build fix + known-limitation docs (v1.12.2)#25
Merged
Merged
Conversation
gmp is keg-only on Homebrew and ships no pkg-config file, so the PKG_CONFIG_PATH prepend can't locate it and configure fails with "GNU MP Library version 4.2 or greater required". Mirror the gettext handling: on Darwin with brew, use --with-gmp=$(brew --prefix gmp). Linux keeps the bare flag (system libgmp-dev). devhardiyanto
Two honest known-limitation entries so users don't file them as bugs: - Windows PECL DLLs aren't SHA-256 verified because windows.php.net publishes no checksums for PECL archives (B3, won't-fix upstream). - ext install sqlsrv/pdo_sqlsrv needs the system-wide MS ODBC Driver; not a phpvm bug (S10.5). devhardiyanto
devhardiyanto
Driver 18 defaults Encrypt=yes, so connections that worked on 17 fail TLS against local/dev SQL Server with a self-signed cert. Document the TrustServerCertificate/Encrypt workaround and the 2012+ requirement so users don't blindly install 18. devhardiyanto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sprint 15 penutup — "close what's closeable". Menutup item backlog yang bisa dieksekusi bersih tanpa keputusan desain/produk: satu langkah build macOS + dua known-limitation doc. Bump 1.12.1 → 1.12.2.
Why
Menuntaskan sisa ROADMAP yang benar-benar actionable. Item lain (B8 split monolit, B11 FPM+nginx, B13 telemetry) sengaja ditunda karena butuh keputusan desain/produk terpisah, bukan effort.
How
gmp— keg-only di Homebrew dan tanpa file pkg-config, jadiPKG_CONFIG_PATHtak menemukannya danconfiguregagal ("GNU MP Library version 4.2 or greater required"). Fix meniru pola--with-gettextyang sudah terbukti: pada Darwin+brew pakai--with-gmp=$(brew --prefix gmp). Linux tetap bare flag (systemlibgmp-dev) — tidak terpengaruh.Changes
linux/phpvm.sh— explicit gmp prefix pada macOS (Darwin-guarded)README.md— entri troubleshootingsqlsrv/ODBC + section "Known limitations" (PECL hash won't-fix, macOS experimental)version.txt+ 4 sumber versi → 1.12.2Paritas OS
Task kode (gmp) hanya menyentuh
linux/phpvm.shby-design: Windows memakai zip PHP prebuilt, tidak build-from-source, jadi tak ada counterpart Windows untuk flag configure. Bukan pelanggaran paritas 1:1.Testing Done
bash -n linux/phpvm.shOKTidak diambil (tetap di backlog)
phpvm.ps1— refactor berisiko, tipe improve (butuh preview+approval)phpvm fpm(kandidat v2.0)