Sprint B8: test coverage Windows 82→168, split phpvm.ps1 jadi modul + build (v1.13.0)#27
Merged
Conversation
libiconv is keg-only on Homebrew and ships no pkg-config file, so configure can't detect it on the default path. Pass the explicit brew prefix on Darwin, mirroring the gmp/gettext handling. Linux keeps --with-iconv bare (resolved from glibc). devhardiyanto
devhardiyanto
The ext block is the largest slice earmarked for the B8 split and had zero tests. Add Pester coverage for Ext-List/Loaded/Info, Get-PECLVersions, the Install-PECLExt guards, Show-ExtRuntimeNotes, Ext-Laravel preset composition and the full Invoke-Ext dispatch table. php.exe is stood in for by a global 'php' function, since the call operator resolves $info.Exe as a command name. Ext-Info is locked at source level so the PHP snippet can't regress into PowerShell interpolation again. devhardiyanto
Get-OlderPatch returns @(), but the output pipeline unrolls a
one-element array into a bare string. Show-OlderPatchHint then hit
StrictMode on .Count ("The property 'Count' cannot be found") and
$older[-1] would have yielded a character instead of a version, so
`phpvm install 8.3.10` threw at the very end whenever exactly one
8.3.x was already installed. Re-wrap at the call site.
Linux is unaffected - _phpvm_older_patches passes newline-joined
text and reads the newest with `tail -1`.
devhardiyanto
Second slice of the B8 safety net: Get-CurrentVersion / Remove-Junction against a real junction, the Invoke-Use guards, Invoke-List, Invoke-Current, Invoke-Uninstall, Invoke-Which, Invoke-Ini and Show-OlderPatchHint - the last of which is what surfaced the single-older-patch crash. Invoke-Use's happy path is deliberately left out: it rewrites the User PATH and broadcasts WM_SETTINGCHANGE, which is not something a test run should do to the machine. Only the pre-PATH guards are asserted. devhardiyanto
Third slice of the B8 safety net: Invoke-Composer (shim guard, openssl pre-step, download failure), Invoke-Cacert (status/update/usage), Invoke-FixIni (all four extension_dir branches), the phpvm hook install/uninstall/status cycle against a redirected $PROFILE, and the two offline branches of Invoke-Upgrade. Nothing here touches the network or the real $PROFILE. The FixIni "already correct" case is written as a convergence test, since the first pass legitimately rewrites a CRLF ini before settling. devhardiyanto
B8. phpvm.ps1 had grown to 1797 lines in one file. Carve it into 15 domain modules under windows/src/ and concatenate them back at build time, so distribution is untouched - the installer and `phpvm upgrade` still fetch a single windows/phpvm.ps1, which stays committed and is now marked GENERATED. Filename prefixes fix the concat order, and that order is load-bearing: 00-header.ps1 opens with param(), which must be the first statement, and 99-entry.ps1 closes with the dispatch switch, which must see every function. No source line was added, dropped or reworded - only moved. CI gains a drift check (./build.ps1 -Check) that fails when phpvm.ps1 and the modules disagree, mirrored by Build.Tests.ps1 for local runs. PSScriptAnalyzer stops recursing into windows/src: a module read alone is a fragment, and linting it that way flags every shared constant as unused. The drift gate is what ties the linted file back to the source. devhardiyanto
devhardiyanto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sprint B8 dalam satu branch: naikkan test coverage Windows dari 82 → 168, lalu pecah
windows/phpvm.ps1(1797 baris) jadi 15 modulwindows/src/yang di-concat balik saat build. Ikut serta B12 (iconv macOS) yang belum sempat di-PR. Bump 1.12.3 → 1.13.0.Why
Syarat asli B8 di ROADMAP: "Risky refactor; do after test coverage feels solid." Saat dicek, 38 dari 65 fungsi
.ps1tak tersentuh test — dan yang kosong justru persis zona yang mau dipotong (seluruh subsistem ext, command handler inti, tools/maint). Memotong di atas jaring bolong = regresi senyap. Jadi test ditulis dulu sebagai enabler, baru split.Versi 1.13.0 (bukan 1.20.0): ada restrukturisasi internal berarti, tapi nol perubahan user-facing.
How
Phase 1 — test dulu (3 commit). Ext subsystem, version commands, tools/maint. Dua teknik yang dipakai berulang:
& $info.Exe -mme-resolveExesebagai nama command, jadi sebuah fungsi globalphpbisa berdiri sebagai pengganti binary aslinya — tak perlu php.exe sungguhan.$env:PHPVM_DIRdiarahkan keTestDrive(dengan junctioncurrentsungguhan),$PROFILEdi-redirect saat menguji hook.Yang sengaja tidak dites: happy-path
Invoke-Use. Ia menulis ulang User PATH dan mem-broadcastWM_SETTINGCHANGE— bukan sesuatu yang boleh dilakukan test run ke mesin developer. Hanya guard sebelum PATH yang di-assert.Bug yang ketemu gara-gara test itu.
Get-OlderPatchmengembalikan@(), tapi output pipeline PowerShell meng-unroll array 1-elemen jadi string telanjang.Show-OlderPatchHintlalu kena StrictMode di.Count(The property 'Count' cannot be found), dan$older[-1]bakal menghasilkan karakter, bukan versi. Efeknya:phpvm install 8.3.10throw di akhir setiap kali ada tepat satu 8.3.x lama terinstall — kasus yang justru paling umum. Linux tak terpengaruh (_phpvm_older_patchespakai teks newline-joined +tail -1).Phase 2 — split (strategi concat-release). Modul dev-time di
windows/src/,build.ps1menyatukannya kembali jadi satuwindows/phpvm.ps1yang tetap ter-commit dan ditandaiGENERATED. Distribusi tidak berubah — installer danphpvm upgradetetap menarik satu file. Prefix angka mengunci urutan concat, dan urutan itu load-bearing:00-header.ps1dibukaparam()(wajib statement pertama),99-entry.ps1ditutup dispatch switch (wajib melihat semua fungsi).Tiga hal yang ketahuan saat assess dan ikut ditangani:
-Recursekewindows/srcmenghasilkan 13 temuan palsu — modul yang dibaca sendirian itu fragment, jadi tiap konstanta bersama terbaca "assigned but never used" dan tiapparam()"declared but not used". Lint sekarang menyasar file hasil-generate (yang memang dikirim ke user) +build.ps1; drift gate yang menjamin file itu = isi modul.src/00-header.ps1, rebuild). Lupa rebuild = jobversion-consistencymerah, bukan senyap.Changes
windows/src/*.ps1(baru, 15 modul) — hasil potongphpvm.ps1; nol baris ditambah, dihapus, atau diubah kata — hanya dipindahwindows/phpvm.ps1— sekarang file hasil-generate, ditandaiGENERATED - DO NOT EDITbuild.ps1(baru) — concat, plus-Checkuntuk drift.github/workflows/ci.yml— step drift check (gating); PSSA berhenti-Recursekesrc/, ikut melintbuild.ps1windows/phpvm.ps1— fix crashShow-OlderPatchHint(viasrc/40-install.ps1)tests/windows/Ext.Tests.ps1,VersionCommands.Tests.ps1,ToolsMaint.Tests.ps1,Build.Tests.ps1(baru) — +86 testlinux/phpvm.sh—--with-iconvprefix Homebrew di macOS (B12, ikut dari branch sebelumnya)README.md— section Development:windows/phpvm.ps1generated, cara rebuildversion.txt+ 4 sumber versi → 1.13.0Testing Done
phpvm.ps1sengaja di-drift → exit 1, rebuild → exit 0phpvm.ps1lama vs baru identik, beda hanya banner GENERATEDCatatan review
Commit
refactor(windows): split ...besar tapi murni pemindahan. Cara tercepat memverifikasi: jalankanpwsh ./build.ps1 -Check, lalu bandingkanphpvm.ps1lama vs baru setelah membuang komentar# --- src/. Yang perlu mata manusia sebenarnya cumabuild.ps1dan perubahanci.yml.Belum dikerjakan (sengaja)
linux/phpvm.sh— sesuai keputusan, Windows dulu untuk membuktikan polanya..shmasih ditulis tangan.Invoke-Use,Invoke-Install,Install-PECLExt/Install-XDebugjalur download — butuh network/PATH nyata; guard-nya sudah tertutup.