test: cover the OpenSSL preflight and build-error surfacing under zsh - #29
Open
devhardiyanto wants to merge 1 commit into
Open
test: cover the OpenSSL preflight and build-error surfacing under zsh#29devhardiyanto wants to merge 1 commit into
devhardiyanto wants to merge 1 commit into
Conversation
The OpenSSL guard and the build-log error surfacing shipped in 1.13.1 were only exercised by bats, which runs under bash - yet the reporter who hit the original failure is a zsh user, so that is the shell the code actually runs in for them. Both were verified by hand at the time; this makes it automatic. Adds the guard matrix (blocks 7.3, allows 8.3, fails open when the probe is silent, honours the bypass) and the three log-surfacing cases, plus the check_status/check_empty helpers they need. Verified to bite: stubbing the guard to always pass turns four checks red. devhardiyanto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test-only. Menutup celah coverage yang tersisa dari v1.13.1: guard OpenSSL dan surface build-error belum diuji di zsh. Tanpa perubahan kode, tanpa bump versi.
Why
Ketahuan saat menindaklanjuti log dari pelapor asli. Prompt-nya
➜— dia pengguna zsh, jadi zsh adalah shell tempat kode itu benar-benar berjalan untuknya. Padahal_phpvm_check_openssl_compatdan_phpvm_show_build_errorhanya ditutupi bats, yang jalan di bash.Keduanya sudah kuverifikasi manual di zsh dan memang jalan — tapi verifikasi manual tak menahan regresi. Mengingat v1.13.1 sendiri lahir dari tiga bug yang hanya muncul di zsh, meninggalkan jalur baru tanpa jaring zsh persis mengulang kesalahan yang baru saja kita perbaiki.
How
Menambah ke
tests/linux/zsh-smoke.zsh:PHPVM_SKIP_OPENSSL_CHECKphpvm install 8.1, nama env bypass)check_status/check_emptyyang dibutuhkan cek di atasProbe OpenSSL di-stub, jadi hasilnya tak bergantung pada apa yang kebetulan terpasang di runner.
Changes
tests/linux/zsh-smoke.zsh— 13 → 23 cekTesting Done
linux/phpvm.shdipastikan tak berubah — diff hanya menyentuh file testCatatan
Tak ada bump versi: ini murni test, jadi biar nebeng rilis berikutnya.