[BUG] Using UIDevice.current on isPhone and isPad variables.

[Zandor300]

If you see the following lines:

https://github.com/dennisweissmann/DeviceKit/blob/master/Source/Device.generated.swift#L584
https://github.com/dennisweissmann/DeviceKit/blob/master/Source/Device.generated.swift#L591

/// Returns whether the device is an iPhone (real or simulator)
public var isPhone: Bool {
  return (isOneOf(Device.allPhones)
          || isOneOf(Device.allSimulatorPhones)
          || UIDevice.current.userInterfaceIdiom == .phone) && !isPod
}

/// Returns whether the device is an iPad (real or simulator)
public var isPad: Bool {
  return isOneOf(Device.allPads)
          || isOneOf(Device.allSimulatorPads)
          || UIDevice.current.userInterfaceIdiom == .pad
}

UIDevice.current is used.

Imagine this example; I'm running on an iPhone X. I'm getting an instance of .iPad6 and checking for .isPhone on that instance. From my understanding, it would return true since (UIDevice.current.userInterfaceIdiom == .phone) == true.

Do note that I haven't tested this.

@dennisweissmann mentioning you since you like that so much 😉 and because I can't assign you.

[Zandor300]

Just confirmed this:

print(Device().description)
        
let ipad = Device.iPad6
print(ipad.isPhone)

Output:

Simulator (iPhone Xs)
true

Would also be the other way around when running on iPad and checking for Device.iPhoneX.isPad.

[dennisweissmann]

Woah that’s a great test case! Thanks for catching that (and sorry for the issue, of course)!

IIRC someone introduced the last or check to be compatible with future releases of phones without updating DeviceKit ...

I’ll think about a better solution for this!

[Zandor300]

Could be fixed like this:

UIDevice.current.userInterfaceIdiom == .phone && isCurrent