Add ingredient editor rows to recipe form - #1203
Draft
dgee2 wants to merge 1 commit into
Draft
Conversation
dgee2
changed the title
dgee2
force-pushed
the
issue-1120-recipe-ingredient-editor
branch
from
August 3, 2026 08:19
47f8cb9 to
158d615
Compare
dgee2
force-pushed
the
issue-1120-recipe-ingredient-editor
branch
from
August 3, 2026 20:11
158d615 to
58cfda4
Compare
dgee2
force-pushed
the
issue-1120-recipe-ingredient-editor
branch
from
August 4, 2026 07:05
58cfda4 to
2b9be76
Compare
Adds a reusable IngredientRowEditor molecule (measure, ingredient, preparation, section, optional toggle) and wires it into new-recipe-form.vue as a dynamic list with add/remove/reorder controls, replacing the hardcoded empty ingredients array from the previous PR. Ingredient/measure text are required per row. Also adds `greedy` to the form's <q-form>: Quasar's QForm.validate() defaults to sequential validation that stops at the first invalid field, so without it only the first invalid row would ever show its error on submit, silently leaving other invalid rows unmarked. Part of #1100. Closes #1120.
dgee2
force-pushed
the
issue-1120-recipe-ingredient-editor
branch
from
August 4, 2026 07:59
2b9be76 to
4c55d70
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable
IngredientRowEditormolecule (measure, ingredient, preparation, section, optional toggle, plus reorder/remove controls) and wires it intonew-recipe-form.vueas a dynamic list, replacing the hardcoded emptyingredients: []from #1119.ingredientText/measureTextare required per row.sortOrderis recomputed from array index at submit time.greedyto the form's<q-form>: Quasar'sQForm.validate()defaults to sequential validation that stops at the first invalid field (confirmed by reading the Quasar source), so without it, submitting a form with multiple invalid fields (e.g. an empty title and an empty ingredient row) would only ever show the first error, silently leaving the rest unmarked.Test plan
pnpm build(type-check + production build)pnpm lintpnpm test:storybook— 21 files / 52 tests passing, including new stories for the row editor (render, edit, move-up/down disabled at boundaries, remove/reorder events) and form-level add/edit/remove/reorder/required-validation coveragegreedyfix)Part of #1100.
Closes #1120.