Add visibility selector to recipe form - #1205
Draft
dgee2 wants to merge 1 commit into
Draft
Conversation
dgee2
changed the title
dgee2
force-pushed
the
issue-1122-recipe-visibility-selector
branch
from
August 3, 2026 08:26
505f419 to
8272fc0
Compare
dgee2
force-pushed
the
issue-1122-recipe-visibility-selector
branch
from
August 3, 2026 20:18
8272fc0 to
ee8b2b6
Compare
dgee2
force-pushed
the
issue-1122-recipe-visibility-selector
branch
from
August 4, 2026 07:05
ee8b2b6 to
8af7bed
Compare
Adds a RecipeVisibilityField molecule wrapping the existing
select-field atom, translating between UpsertRecipe.accessScope's
raw string values ("Private" / "AuthenticatedUsers") and the
underlying QSelect's {label, value} option shape. Wired into
new-recipe-form.vue, replacing the hardcoded "Private" literal in
the submit payload; defaults to Private for new recipes.
Part of #1100. Closes #1122.
dgee2
force-pushed
the
issue-1122-recipe-visibility-selector
branch
from
August 4, 2026 07:59
8af7bed to
e8e2152
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
RecipeVisibilityFieldmolecule wrapping the existingselect-field.vueatom, translating betweenUpsertRecipe.accessScope's raw string values (Private/AuthenticatedUsers) and the underlyingQSelect's{label, value}option shape.Privatefor new recipes.new-recipe-form.vue, replacing the hardcoded'Private'literal in the submit payload — the selected value now flows through toUpsertRecipe.accessScope.This is the last PR in the #1099/#1100 stacked sequence.
Test plan
pnpm build(type-check + production build)pnpm lintpnpm test:storybook— 23 files / 65 tests passing, including a real dropdown-open-and-select interaction test (verified genuine, not a false positive, by temporarily sabotaging the assertion and confirming it fails correctly)Part of #1100.
Closes #1122.