You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@MattFromRVA thanks for the PR! Indeed, it's an unpleasant bug and it's nice to have it fixed.
P.S. A side note: the whole Characteristic* infrastructure is a huge technical debt introduced in 2016. Back in those times, I had no idea about the actual feature set we needed, so I tried to design a flexible and generic approach. Unfortunately, the API turned out to be over-complicated, which is quite challenging to maintain. In my backlog, I have a long-living task of burning Characteristic* and redesigning the Job API from scratch targeting the current set of features. However, this task is not product-critical (the current system just works most of the time), so it's always deprioritized (no ETA for now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2473