Add a static flag in EF that will be set when code is being executed for design-time discovery - #28508
Merged
Conversation
Contributor
Author
|
@bricelam Is there a better way to test this? |
bricelam
reviewed
Jul 25, 2022
bricelam
left a comment
bricelam
left a comment
Contributor
There was a problem hiding this comment.
We should also set it in DbContextActivator.CreateInstance.
Contributor
This is exactly how I'd do it. |
ajcvickers
force-pushed
the
StopLookAndListen0725
branch
from
July 26, 2022 10:54
3920690 to
fae4e6e
Compare
Contributor
Author
|
@bricelam New version up. |
bricelam
suggested changes
Jul 26, 2022
bricelam
left a comment
bricelam
left a comment
Contributor
There was a problem hiding this comment.
We should also set it in DbContextActivator.CreateInstance. That's is what ASP.NET Scaffolding uses at design-time.
ajcvickers
force-pushed
the
StopLookAndListen0725
branch
from
July 28, 2022 13:47
fae4e6e to
f55557b
Compare
bricelam
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27306.