Upgrade to VS 2017#179
Merged
Merged
Conversation
muratg
approved these changes
Dec 15, 2016
| <PropertyGroup> | ||
| <RepositoryUrl>https://github.com/aspnet/PlatformAbstractions</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)Key.snk</AssemblyOriginatorKeyFile> |
There was a problem hiding this comment.
MSBuildThisFileDirectory value has a trailing backspace?
Author
There was a problem hiding this comment.
Yup, always. cref https://msdn.microsoft.com/en-us/library/ms164309.aspx
Author
|
⌚ on aspnet/Universe#466 to merge |
This was referenced Dec 15, 2016
Eilon
approved these changes
Dec 15, 2016
|
|
||
| <PropertyGroup> | ||
| <Description>Command-line parsing API. Commonly used types: | ||
| Microsoft.Extensions.CommandLineUtils.CommandLineApplication |
There was a problem hiding this comment.
Love the newlines! 😄 Do they end up showing up correctly in the package's nuspec?
natemcmaster
force-pushed
the
namc/vs2017
branch
from
December 15, 2016 20:01
8272bc0 to
ffb7c20
Compare
cesarblum
reviewed
Jan 18, 2017
| <Import Project="..\.build\common.props" Condition="Exists('..\.build\common.props')" /> | ||
|
|
||
| <PropertyGroup> | ||
| <RepositoryUrl>https://github.com/aspnet/PlatformAbstractions</RepositoryUrl> |
There was a problem hiding this comment.
https://github.com/aspnet/Common
Author
There was a problem hiding this comment.
yeah, I caught that later :)
natemcmaster
pushed a commit
that referenced
this pull request
Nov 5, 2018
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade this solution to build with VS 2017 and dotnet-cli 1.0.0-preview4.
cc @Eilon @muratg