Reacting to changes to MemoryManager (remove Length)#336
Merged
Conversation
Author
Actually, given Length was a virtual property (not required to be overridden) and there is no one referencing MemoryPoolBlock.Length, we can merge this as is (not a source breaking change to aspnet). MemoryPoolBlock (Debug) is an internal sealed class (and no one outside of the Common repo uses it anyway). cc @joshfree |
Member
return new Memory<byte>(this, 0, _length);will also need to change to call the return CreateMemory(_length);As that public .ctor is now internal (due to its unsafe nature) |
Author
Good point. Thanks for the reminder. We can still remove the Length property though. I will address this change separately. Can we merge this @pakrym? |
pakrym
approved these changes
Apr 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/dotnet/corefx/issues/28751
Depends on new corefx packages with this change: dotnet/corefx#28981cc @davidfowl, @pakrym, @KrzysztofCwalina, @GrabYourPitchforks, @benaadams