"Clean-up hotreloads repo and define TFM centrally" & "Fix wrong TFM in shipping targets file" - #230
Merged
Merged
Conversation
- Define TFM centrally for all projects and update docs - Remove IsPackable=false which is the default Arcade setting - Define Nullable=enable centrally for non test projects - Remove not needed msbuild xml syntax and clean-up project files - Style nits
akoeplinger
approved these changes
Jan 11, 2023
akoeplinger
left a comment
akoeplinger
left a comment
Member
There was a problem hiding this comment.
Looks good except one change, thanks!
…soft.DotNet.HotReload.Utils.Generator.BuildTool.csproj Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1: Clean-up hotreloads repo and define TFM centrally
Commit 2: Fix wrong TFM in shipping targets file
cc @lambdageek