Skip to content

Add try except around command creation/invocation. - #9

Merged
russellhadley merged 2 commits into
dotnet:masterfrom
russellhadley:GuardCommandInvoke
Jul 1, 2016
Merged

Add try except around command creation/invocation.#9
russellhadley merged 2 commits into
dotnet:masterfrom
russellhadley:GuardCommandInvoke

Conversation

@russellhadley

Copy link
Copy Markdown
Contributor

Adds a guard and error message around commands to make a more graceful
experience when a tool isn't on the path.

Adds a guard and error message around commands to make a more graceful
experience when a tool isn't on the path.
@russellhadley

Copy link
Copy Markdown
Contributor Author

@AndyAyersMS - Hardens command creation and adds a more sensible error message. Should be last element of #1. (I'm going to open a separate issue for updating the frameworks due to reconciling the list with the .NETStandard set)

@russellhadley

Copy link
Copy Markdown
Contributor Author

@pgavlin take a look?

Comment thread src/jit-analyze/jit-analyze.cs Outdated
}
catch (CommandUnknownException e)
{
Console.WriteLine("\nError: git command not found! Add git to the environment path.\n", e);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Console.Error

Use Console.Error.WriteLine where appropraite for error output.
@russellhadley

Copy link
Copy Markdown
Contributor Author

@pgavlin Added separate commit for switching appropriate output to stderr.

@pgavlin

pgavlin commented Jul 1, 2016

Copy link
Copy Markdown

LGTM

@russellhadley
russellhadley merged commit 61ea206 into dotnet:master Jul 1, 2016
richlander pushed a commit that referenced this pull request Jun 1, 2026
* In-built Trimmer

* Create Utilities project

* minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants