Skip to content

Remove unnecessary FileLoadLevel values - #105673

Merged
elinor-fung merged 1 commit into
dotnet:mainfrom
elinor-fung:unused-fileloadlevel
Jul 30, 2024
Merged

Remove unnecessary FileLoadLevel values#105673
elinor-fung merged 1 commit into
dotnet:mainfrom
elinor-fung:unused-fileloadlevel

Conversation

@elinor-fung

Copy link
Copy Markdown
Member

I think these were left from NGEN. Remove levels that don't do anything now:

  • FILE_LOAD_FIND_NATIVE_IMAGE
  • FILE_LOAD_VERIFY_NATIVE_IMAGE_DEPENDENCIES
  • FILE_LOAD_ADD_DEPENDENCIES
  • FILE_LOAD_PRE_LOADLIBRARY
  • FILE_LOAD_LOADLIBRARY

Rename FILE_LOAD_POST_LOADLIBRARY to FILE_LOAD_POST_ALLOCATE.

@ghost ghost added the area-AssemblyLoader-coreclr only use for closed issues label Jul 30, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@elinor-fung

Copy link
Copy Markdown
Member Author

/ba-g timeout on leg unaffected by this change - windows arm64 NativeAOT

@elinor-fung
elinor-fung merged commit e226861 into dotnet:main Jul 30, 2024
@elinor-fung
elinor-fung deleted the unused-fileloadlevel branch July 30, 2024 19:39
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-AssemblyLoader-coreclr only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants