Replace VectorXx.Exp's edge case fallback with scalar processing - #107886
Merged
Conversation
The better, vectorized fix is more complex and can be done for .NET 10.
stephentoub
requested review from
eiriktsarpalis,
jeffhandley,
michaelgsharp and
tannergooding
September 16, 2024 20:20
ghost
added
the
jeffhandley
reviewed
Sep 17, 2024
jeffhandley
left a comment
jeffhandley
left a comment
Member
There was a problem hiding this comment.
After hitting Approve, I noticed there's a failing test for the special values.
Member
Author
|
/backport to release/9.0-rc2 |
Contributor
|
Started backporting to release/9.0-rc2: https://github.com/dotnet/runtime/actions/runs/10909076272 |
4 tasks
3 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…net#107886) * Replace VectorXx.Exp's edge case fallback with scalar processing The better, vectorized fix is more complex and can be done for .NET 10. * Revert addition to Helpers.IsEqualWithTolerance
Contributor
do you guys remember this or should i create an issue for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The better, vectorized fix is more complex and can be done for .NET 10.
Fixes #107838
Easiest to review with whitespace hidden: https://github.com/dotnet/runtime/pull/107886/files?diff=split&w=1