[mono][tasks] reduce large allocations in build tasks - #112295
Merged
Conversation
ghost
added
the
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/tasks/Common/Utils.cs:217
- Ensure that the new behavior introduced by the CompareFiles method is covered by tests. This includes scenarios where files are identical and where they differ.
private static bool CompareFiles(string filePath1, string filePath2)
This was referenced Feb 8, 2025
lewing
commented
Feb 8, 2025
This was referenced Feb 9, 2025
Open
Closed
lewing
force-pushed
the
compare-better
branch
from
February 12, 2025 22:10
4e07393 to
218f024
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/tasks/Common/Utils.cs:270
- Ensure that the new behavior in CopyIfDifferent using ContentEqual is covered by tests.
bool areDifferent = !File.Exists(dst) || !ContentEqual(src, dst);
akoeplinger
approved these changes
Feb 12, 2025
lewing
commented
Feb 13, 2025
| } | ||
| } | ||
|
|
||
| #pragma warning disable IDE0060 // Remove unused parameter |
Member
Author
There was a problem hiding this comment.
I'm certain there is a difference between the text comparison and bytewise comparison but I think any value is likely an artifact of history that no longer applies. I'm happy to remove the setting at the callers and will unless someone objects.
This comment was marked as outdated.
This comment was marked as outdated.
lewing
marked this pull request as ready for review
February 13, 2025 03:08
lewing
changed the title
This was referenced Feb 13, 2025
Member
Author
|
/ba-g issue files for red BA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's late on a Friday so it is likely I'm missing something, but the hash comparison doesn't appear to be useful at all, that said I will assume it is useful and preserve the original behavior for now.
Use two rolling buffers to do file equality comparison since Read can return less than a full buffer, only advance a buffer once it is consumed, and compare the overlapping region.