[release/9.0-staging] Update dependencies from dotnet/xharness - #130598
Conversation
…60710.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26360.1
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "c6f6852a8f67765dfffde5c2b56c176d32eb6686",
"last_dispatched_base_ref": "release/9.0-staging",
"last_dispatched_base_sha": "80af84177afb7fdf8ef743df3065b0d835f92b97",
"last_reviewed_commit": "c6f6852a8f67765dfffde5c2b56c176d32eb6686",
"last_reviewed_base_ref": "release/9.0-staging",
"last_reviewed_base_sha": "80af84177afb7fdf8ef743df3065b0d835f92b97",
"last_recorded_worker_run_id": "29719316876",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "ba283771db087c681334ea006e185e12d26de989",
"review_id": 4730543359
},
{
"commit": "c6f6852a8f67765dfffde5c2b56c176d32eb6686",
"review_id": 4732405286
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: This is an automated Maestro dependency-flow PR into release/9.0-staging that advances the dotnet/xharness dependencies from 11.0.0-prerelease.26353.1 to 11.0.0-prerelease.26360.1 (xharness commit 4da0015e9d → ab06ed6b9b).
Approach: The change updates the three XHarness package versions in the standard three locations kept in sync by the tooling: .config/dotnet-tools.json (the microsoft.dotnet.xharness.cli tool version), eng/Version.Details.xml (the three Microsoft.DotNet.XHarness.* dependencies plus their source SHAs), and eng/Versions.props (the corresponding MicrosoftDotNetXHarness*Version properties). No source, test, or build-logic files are touched.
Summary: The version bump is consistent across all three files — the same target version 11.0.0-prerelease.26360.1 is applied everywhere, and the two Version.Details.xml SHAs both point to the single new xharness commit ab06ed6b9b6366d219751bdd80b04f8f37768bb3. This matches the expected shape of a Maestro dependency update and carries the risk profile typical of a test-infrastructure (XHarness) prerelease bump: impact is limited to the mobile/browser test harness tooling rather than shipping product code. There are no actionable findings. Correctness ultimately depends on the referenced xharness build being valid and on CI passing; verify the mobile/WASM test legs are green before merging.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 29.3 AIC · ⌖ 14.4 AIC · ⊞ 10K
…60718.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26368.1
There was a problem hiding this comment.
Holistic Review
Motivation: This is an automated Maestro dependency-flow PR into release/9.0-staging that advances the dotnet/xharness dependencies. Since the prior review, the PR patch was updated: it now targets 11.0.0-prerelease.26368.1 (xharness commit acc639bea6c5720abf118b8808e18f9cabe90568) instead of the previously-reviewed 11.0.0-prerelease.26360.1 (ab06ed6b9b), advancing from the original 11.0.0-prerelease.26353.1 (4da0015e9d).
Approach: The incremental change (commit c6f6852a8f67) re-applies the same three-file version bump — .config/dotnet-tools.json, eng/Version.Details.xml (three Microsoft.DotNet.XHarness.* dependencies plus their source SHAs), and eng/Versions.props — retargeted to the newer xharness build. It additionally removes a now-empty darc-pub-dotnet-emsdk-8e475db package source line from NuGet.config, which Maestro prunes when the emsdk source set is emptied (the Begin/End: Package sources from dotnet-emsdk markers remain, now with no entries). No source, test, or build-logic files are touched.
Summary: The bump remains internally consistent — the same target version 11.0.0-prerelease.26368.1 is applied everywhere, and both Version.Details.xml SHAs point to the single new xharness commit acc639bea6c5720abf118b8808e18f9cabe90568. The NuGet.config source removal is a benign, well-formed edit that leaves the automation-managed markers intact. This matches the expected shape of a Maestro dependency update; risk is limited to mobile/browser test-harness tooling rather than shipping product code. There are no actionable findings. Correctness ultimately depends on the referenced xharness build being valid and on CI passing; verify the mobile/WASM test legs are green before merging.
Assessment History
- review 4730543359 (commit
ba283771db08): verdict LGTM (no actionable findings). Current verdict: LGTM (no actionable findings). Assessment changed in detail only: the PR patch was updated to retarget the XHarness bump from26360.1to26368.1and to prune an emptydotnet-emsdkNuGet source, but the motivation (automated dependency flow), approach (standard three-location version sync), and low risk profile (test-infrastructure tooling) are unchanged. The verdict remains LGTM.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 50.8 AIC · ⌖ 14.7 AIC · ⊞ 10K
…5aeb-d105-4528-b563-346da8b25ff4
…60720.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26370.1
|
/ba-g Only known failures. |
This pull request updates the following dependencies
From https://github.com/dotnet/xharness