[release/10.0] Update dependencies from dotnet/xharness - #130599
Conversation
…60710.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26360.1
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "180687da96fceec4487c677370cf742a2bf3fd95",
"last_dispatched_base_ref": "release/10.0",
"last_dispatched_base_sha": "4159de00b8500dbdb610fa6a6b6db30f1836affc",
"last_reviewed_commit": "180687da96fceec4487c677370cf742a2bf3fd95",
"last_reviewed_base_ref": "release/10.0",
"last_reviewed_base_sha": "4159de00b8500dbdb610fa6a6b6db30f1836affc",
"last_recorded_worker_run_id": "29719318265",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "07dc13e008a8ebe27194c6260b5cfe511fbaadae",
"review_id": 4730543562
},
{
"commit": "180687da96fceec4487c677370cf742a2bf3fd95",
"review_id": 4732403266
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: Automated Maestro dependency flow updating the dotnet/xharness dependencies on the release/10.0 branch from 11.0.0-prerelease.26353.1 to 11.0.0-prerelease.26360.1.
Approach: Straightforward version bump across the three coordinated locations: the microsoft.dotnet.xharness.cli tool version in .config/dotnet-tools.json, the three MicrosoftDotNetXHarness*PackageVersion properties in eng/Version.Details.props, and the corresponding Microsoft.DotNet.XHarness.* dependency entries (version plus commit SHA 4da0015e... → ab06ed6b...) in eng/Version.Details.xml.
Summary: LGTM. The change is a mechanical, internally consistent dependency update. All three XHarness packages move to the same new version, the tool manifest and both version manifests agree, and the Version.Details.xml SHA is updated to match the referenced xharness build. XHarness is test-infrastructure tooling only, so there is no product/runtime code impact; the effective validation is the CI test run itself. No functional risk and no actionable findings.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 28.5 AIC · ⌖ 10.1 AIC · ⊞ 10K
…60718.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26368.1
There was a problem hiding this comment.
Holistic Review
Motivation: This is an automated dependency-flow (darc) update that bumps the Microsoft.DotNet.XHarness.CLI, Microsoft.DotNet.XHarness.TestRunners.Common, and Microsoft.DotNet.XHarness.TestRunners.Xunit dependencies sourced from dotnet/xharness. XHarness is the test-execution harness used for device/simulator and WASM test runs, so keeping it current on release/10.0 maintains parity with upstream fixes.
Approach: The PR touches only mechanical, tool-generated files: .config/dotnet-tools.json, eng/Version.Details.props, eng/Version.Details.xml, and NuGet.config. Package versions and the corresponding commit SHAs are updated in lockstep. The incremental change since the prior review advances the target build from 11.0.0-prerelease.26360.1 to 11.0.0-prerelease.26368.1 and removes a stale darc-pub-dotnet-dotnet-d92b8de package source from NuGet.config (darc pruned an unused source). No product or test source code is modified.
Summary: LGTM. The changes are consistent and internally coherent — the version strings in dotnet-tools.json, Version.Details.props, and Version.Details.xml all agree at 26368.1, and the SHAs in Version.Details.xml are updated together. The NuGet.config feed removal is a normal darc source-cleanup and the remaining feeds are unaffected. There are no behavioral or security concerns beyond trusting the upstream xharness bump, which is validated by CI. Merge readiness depends on the associated arcade/xharness CI legs passing.
Assessment History
- review 4730543562 reviewed commit
07dc13e008a8(xharness26360.1) with an LGTM/approve verdict. The current verdict remains LGTM — assessment unchanged in motivation, approach, and risk. The only differences are the newer target build (26368.1) and the removal of one stale NuGet source, both routine dependency-flow mechanics.
Detailed Findings
No actionable findings. All modified files are dependency-flow-generated metadata with consistent, lockstep updates.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 40.3 AIC · ⌖ 10.4 AIC · ⊞ 10K
…-abd1-466ab0abb882
|
/ba-g only known |
…60720.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26370.1
|
/ba-g only known and explicitly skipped linker tests |
This pull request updates the following dependencies
From https://github.com/dotnet/xharness