Skip to content

[release/10.0] Update dependencies from dotnet/xharness - #130599

Merged
mrek-msft merged 4 commits into
release/10.0from
darc-release/10.0-ddb2c384-f976-444b-abd1-466ab0abb882
Jul 31, 2026
Merged

[release/10.0] Update dependencies from dotnet/xharness#130599
mrek-msft merged 4 commits into
release/10.0from
darc-release/10.0-ddb2c384-f976-444b-abd1-466ab0abb882

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/xharness

…60710.1

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26360.1
@github-actions github-actions Bot added the area-codeflow for labeling automated codeflow label Jul 13, 2026
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Workflow state for the Holistic Review Orchestrator.

{
  "version": 5,
  "last_dispatched_commit": "180687da96fceec4487c677370cf742a2bf3fd95",
  "last_dispatched_base_ref": "release/10.0",
  "last_dispatched_base_sha": "4159de00b8500dbdb610fa6a6b6db30f1836affc",
  "last_reviewed_commit": "180687da96fceec4487c677370cf742a2bf3fd95",
  "last_reviewed_base_ref": "release/10.0",
  "last_reviewed_base_sha": "4159de00b8500dbdb610fa6a6b6db30f1836affc",
  "last_recorded_worker_run_id": "29719318265",
  "review_attempt_commit": "",
  "review_attempt_base_ref": "",
  "review_attempt_count": 0,
  "max_review_attempts": 5,
  "review_history_format": "holistic-review-disclosure-v1",
  "review_history": [
    {
      "commit": "07dc13e008a8ebe27194c6260b5cfe511fbaadae",
      "review_id": 4730543562
    },
    {
      "commit": "180687da96fceec4487c677370cf742a2bf3fd95",
      "review_id": 4732403266
    }
  ]
}

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review

Motivation: Automated Maestro dependency flow updating the dotnet/xharness dependencies on the release/10.0 branch from 11.0.0-prerelease.26353.1 to 11.0.0-prerelease.26360.1.

Approach: Straightforward version bump across the three coordinated locations: the microsoft.dotnet.xharness.cli tool version in .config/dotnet-tools.json, the three MicrosoftDotNetXHarness*PackageVersion properties in eng/Version.Details.props, and the corresponding Microsoft.DotNet.XHarness.* dependency entries (version plus commit SHA 4da0015e...ab06ed6b...) in eng/Version.Details.xml.

Summary: LGTM. The change is a mechanical, internally consistent dependency update. All three XHarness packages move to the same new version, the tool manifest and both version manifests agree, and the Version.Details.xml SHA is updated to match the referenced xharness build. XHarness is test-infrastructure tooling only, so there is no product/runtime code impact; the effective validation is the CI test run itself. No functional risk and no actionable findings.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 28.5 AIC · ⌖ 10.1 AIC · ⊞ 10K

…60718.1

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26368.1

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review

Motivation: This is an automated dependency-flow (darc) update that bumps the Microsoft.DotNet.XHarness.CLI, Microsoft.DotNet.XHarness.TestRunners.Common, and Microsoft.DotNet.XHarness.TestRunners.Xunit dependencies sourced from dotnet/xharness. XHarness is the test-execution harness used for device/simulator and WASM test runs, so keeping it current on release/10.0 maintains parity with upstream fixes.

Approach: The PR touches only mechanical, tool-generated files: .config/dotnet-tools.json, eng/Version.Details.props, eng/Version.Details.xml, and NuGet.config. Package versions and the corresponding commit SHAs are updated in lockstep. The incremental change since the prior review advances the target build from 11.0.0-prerelease.26360.1 to 11.0.0-prerelease.26368.1 and removes a stale darc-pub-dotnet-dotnet-d92b8de package source from NuGet.config (darc pruned an unused source). No product or test source code is modified.

Summary: LGTM. The changes are consistent and internally coherent — the version strings in dotnet-tools.json, Version.Details.props, and Version.Details.xml all agree at 26368.1, and the SHAs in Version.Details.xml are updated together. The NuGet.config feed removal is a normal darc source-cleanup and the remaining feeds are unaffected. There are no behavioral or security concerns beyond trusting the upstream xharness bump, which is validated by CI. Merge readiness depends on the associated arcade/xharness CI legs passing.

Assessment History

  • review 4730543562 reviewed commit 07dc13e008a8 (xharness 26360.1) with an LGTM/approve verdict. The current verdict remains LGTM — assessment unchanged in motivation, approach, and risk. The only differences are the newer target build (26368.1) and the removal of one stale NuGet source, both routine dependency-flow mechanics.

Detailed Findings

No actionable findings. All modified files are dependency-flow-generated metadata with consistent, lockstep updates.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 40.3 AIC · ⌖ 10.4 AIC · ⊞ 10K

@mrek-msft

Copy link
Copy Markdown
Member

/ba-g only known

@mrek-msft mrek-msft added the Servicing-approved Approved for servicing release label Jul 22, 2026
…60720.1

On relative base path root
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 11.0.0-prerelease.26353.1 -> To Version 11.0.0-prerelease.26370.1
@mrek-msft

Copy link
Copy Markdown
Member

/ba-g only known and explicitly skipped linker tests

@mrek-msft
mrek-msft merged commit 796a381 into release/10.0 Jul 31, 2026
158 of 160 checks passed
@mrek-msft
mrek-msft deleted the darc-release/10.0-ddb2c384-f976-444b-abd1-466ab0abb882 branch July 31, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant