Added Baseline Test - #283
Merged
Merged
Conversation
43081j
reviewed
Jul 8, 2026
|
|
||
| const [featuresByFile, detectedTarget, detectedBaselineYear] = | ||
| await Promise.all([ | ||
| detectFeatures({ cwd: scanDir }), |
Contributor
There was a problem hiding this comment.
fine for now but these 3 will basically run the same scan just with a different output.
i should probably change the detectFeatures result to be {features, target, year} or something
Collaborator
Author
There was a problem hiding this comment.
Would be nice as I want all three
43081j
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in James https://github.com/43081j/baseline-detector as a test, the last one before we move to starlight.
I added some filters to make sure we only check browser code and not server stuff. Be interesting to see what these stats are once we start bumping the framework versions.