Skip to content

[22955] Get correct Fast CDR related branch in CI#220

Merged
rsanchez15 merged 1 commit into
mainfrom
test/ci-related-branch
Apr 3, 2025
Merged

[22955] Get correct Fast CDR related branch in CI#220
rsanchez15 merged 1 commit into
mainfrom
test/ci-related-branch

Conversation

@Carlosespicur

@Carlosespicur Carlosespicur commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds Fast CDR branch selection in jobs, similarly to how it is done in Fast DDS Ubuntu CI.

@Mergifyio backport 2.1.x 2.0.x 1.4.x 1.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur
Refs #22955: Add Fast CDR branch selection in reusable jobs
95b3e79 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur added the no-test Skip CI tests if PR marked with this label label Mar 24, 2025
@Carlosespicur
Carlosespicur requested a review from Mario-DL March 24, 2025 11:37
@github-actions github-actions Bot added the ci-pending PR which CI is running label Mar 24, 2025
Mario-DL
Mario-DL approved these changes Mar 27, 2025
View reviewed changes

@Mario-DL Mario-DL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We should include corresponding backports

@rsanchez15
rsanchez15 merged commit c7b1678 into main Apr 3, 2025
@rsanchez15
rsanchez15 deleted the test/ci-related-branch branch April 3, 2025 06:28
@Carlosespicur

Carlosespicur commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

@Mergifyio backport 2.1.x 2.0.x 1.4.x 1.2.x 1.0.x

@mergify

mergify Bot commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown

backport 2.1.x 2.0.x 1.4.x 1.2.x 1.0.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 3, 2025
@Carlosespicur @mergify
Add Fast CDR branch selection in reusable jobs (#220)
f7ada2e 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)
mergify Bot pushed a commit that referenced this pull request Apr 3, 2025
@Carlosespicur @mergify
Add Fast CDR branch selection in reusable jobs (#220)
f6d94c7 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)
This was referenced Apr 3, 2025
Merged
Closed
mergify Bot pushed a commit that referenced this pull request Apr 3, 2025
@Carlosespicur @mergify
Add Fast CDR branch selection in reusable jobs (#220)
6afb1b7 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)
@mergify mergify Bot mentioned this pull request Apr 3, 2025
Merged
8 tasks
mergify Bot pushed a commit that referenced this pull request Apr 3, 2025
@Carlosespicur @mergify
Add Fast CDR branch selection in reusable jobs (#220)
a1ca45e 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)
mergify Bot pushed a commit that referenced this pull request Apr 3, 2025
@Carlosespicur @mergify
Add Fast CDR branch selection in reusable jobs (#220)
c6376e3 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)
This was referenced Apr 3, 2025
Merged
Merged
Mario-DL pushed a commit that referenced this pull request Apr 4, 2025
@mergify @Carlosespicur
Get correct Fast CDR related branch in CI (backport #220) (#227)
62aca96 
* Add Fast CDR branch selection in reusable jobs (#220)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)

* Update Fast CDR branch

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Skip base branch in Fast CDR branch selection

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Mario-DL pushed a commit that referenced this pull request Apr 4, 2025
@mergify @Carlosespicur
Get correct Fast CDR related branch in CI (#224)
8d866a7 
* Add Fast CDR branch selection in reusable jobs (#220)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)

* Update Fast CDR branch

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Skip base branch in Fast CDR branch selection

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Mario-DL pushed a commit that referenced this pull request Apr 4, 2025
@mergify @Carlosespicur
Get correct Fast CDR related branch in CI (#226)
3685455 
* Add Fast CDR branch selection in reusable jobs (#220)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)

* Update Fast CDR branch

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Skip base branch in Fast CDR branch selection

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Mario-DL pushed a commit that referenced this pull request Apr 4, 2025
@mergify @Carlosespicur
Get correct Fast CDR related branch in CI (#228)
6e05c12 
* Add Fast CDR branch selection in reusable jobs (#220)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit c7b1678)

* Update Fast CDR branch

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Skip base branch in Fast CDR branch selection

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
@juanlofer-eprosima juanlofer-eprosima added this to the v2.2.1 milestone Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Mario-DL Mario-DL Mario-DL approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Milestone

v2.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Carlosespicur @Mario-DL @rsanchez15 @juanlofer-eprosima