Skip to content

sampleLoad: orso.load_orso runs outside try/except and crashes on bad ORSO files #322

Description

@rozyczko

Source: EasyReflectometryApp/Backends/Py/project.py:127-147 — DEEP_ANALYSIS.md §5 item 11

In the sampleLoad slot, orso.load_orso(...) runs outside any try/except. A malformed or unreadable ORSO file raises straight through the slot into the Qt event loop.

Contrast with load() directly above, which carefully catches errors and signals projectLoadError.

Fix: Wrap the ORSO load in try/except and report failures via an error signal (e.g. projectLoadError) as the project-load path does.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions