DescriptorArray - #105
Merged
Merged
Conversation
Closed
![github-actions[bot]](https://cdn.github.com/in/15368?s=60&v=4){kind=small}
damskii9992
requested changes
Mar 5, 2025
damskii9992
left a comment
damskii9992
left a comment
Contributor
There was a problem hiding this comment.
I don't really know if I'm in favour of the smooth_operator implementation. More verbose code is sometimes better if it produces more readable code, but we should also get another persons opinion on this.
rozyczko
reviewed
Mar 5, 2025
elindgren
force-pushed
the
DescriptorArray2_scipp_strikes_back
branch
from
March 6, 2025 08:13
e31308a to
d93eadc
Compare
henrikjacobsenfys
left a comment
henrikjacobsenfys
left a comment
Member
There was a problem hiding this comment.
Well done! Just a few issues.
Collaborator
Author
|
I think that should be everything taken care of! We can merge if you guys are happy imo Edit: @damskii9992 re-requested the review from you since you requested changes. |
damskii9992
approved these changes
Mar 7, 2025
damskii9992
left a comment
damskii9992
left a comment
Contributor
There was a problem hiding this comment.
ValueError string is incomplete, but otherwise I would finally say this is ready to be merged :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
DescriptorArraytype, defined in #95 and #103Fixes #103