fix createRenderInfo TypeError in default title case#2169
Merged
lucas-koehler merged 9 commits intoAug 11, 2023
Merged
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@sdirix see test case here--I think there's a bug if there's neither a resolved schema or a title. |
DrewHoo
changed the title
lucas-koehler
approved these changes
Aug 11, 2023
lucas-koehler
left a comment
lucas-koehler
left a comment
Contributor
There was a problem hiding this comment.
Hi @DrewHoo
thank you very much for the contribution <3
The fix and the test case look good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized there's a possible error here, added a test & fix for it in last commit