Skip to content

generate a control for enums in generated uischema#2189

Merged
lucas-koehler merged 1 commit into
eclipsesource:masterfrom
LukasBoll:enum_generated_uischema
Oct 25, 2023
Merged

generate a control for enums in generated uischema#2189
lucas-koehler merged 1 commit into
eclipsesource:masterfrom
LukasBoll:enum_generated_uischema

Conversation

@LukasBoll

Copy link
Copy Markdown
Contributor

closes #2177

@netlify

netlify Bot commented Oct 10, 2023

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 6e38cea
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65379c01ca298c0008782c00
😎 Deploy Preview https://deploy-preview-2189--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LukasBoll
LukasBoll force-pushed the enum_generated_uischema branch from b6ebee9 to 14842a5 Compare October 10, 2023 16:12
@coveralls

coveralls commented Oct 10, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 84.469%. remained the same when pulling 6e38cea on LukasBoll:enum_generated_uischema into 9146b0f on eclipsesource:master.

@LukasBoll
LukasBoll force-pushed the enum_generated_uischema branch from 14842a5 to b88cbe7 Compare October 22, 2023 20:57
Previously, enums without type-attribute weren't recognized by the
derive types function, leading to omitted enums in generated uischemas.

Closes eclipsesource#2177
@LukasBoll
LukasBoll force-pushed the enum_generated_uischema branch from b88cbe7 to 6e38cea Compare October 24, 2023 10:27
@lucas-koehler
lucas-koehler self-requested a review October 24, 2023 12:19
Comment thread packages/core/src/util/util.ts

@lucas-koehler lucas-koehler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@lucas-koehler
lucas-koehler merged commit f905c82 into eclipsesource:master Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enum without "type" can't be rendered

4 participants