fix element label in vue array renderer#2191
Merged
Merged
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LukasBoll
changed the title
LukasBoll
force-pushed
the
fix_vue_array
branch
from
October 20, 2023 14:21
87f37a5 to
c27d702
Compare
LukasBoll
changed the title
Replaced `isNaN` with `Number.isNaN` to ensure accurate checks. `isNaN` returns true for most text values, resulting in labels not being shown in the array renderer. closes eclipsesource#2157
LukasBoll
force-pushed
the
fix_vue_array
branch
from
October 24, 2023 10:50
c27d702 to
e09f657
Compare
sdirix
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2157