fix(material): Resolve refs in object renderer#2202
Merged
sdirix merged 1 commit intoNov 13, 2023
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sdirix
requested changes
Oct 31, 2023
sdirix
left a comment
sdirix
left a comment
Member
There was a problem hiding this comment.
Looks good! Can you also check all other invocations of Generate.uiSchema in the code base? We are missing the extra parameters in multiple places.
Previously, UI schemas generated by JsonForms were incomplete in many instances because not all references were resolved. This commit addresses the issue by providing the root schema to all usages of the Generate.uischema function, ensuring the resolution of all references. Closes eclipsesource#2187
LukasBoll
force-pushed
the
fix/resolve_ref_in_object_renderer
branch
from
November 6, 2023 20:04
00165a3 to
0f1fc78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, UI schemas generated in the Material object renderer were incomplete because not all refs could be resolved.
Closes #2187