Skip to content

Add Angular Material Autocomplete test#2217

Merged
sdirix merged 2 commits into
eclipsesource:masterfrom
howdyAnkit:jasmine-desolate
Dec 12, 2023
Merged

Add Angular Material Autocomplete test#2217
sdirix merged 2 commits into
eclipsesource:masterfrom
howdyAnkit:jasmine-desolate

Conversation

@howdyAnkit

Copy link
Copy Markdown
Contributor

Fixes #1239

#1239

Fixed Jasmine test cases for one of the function
And added jasmine for the assigned Issue.

@netlify

netlify Bot commented Nov 20, 2023

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit c33c50d
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/655afeb6c635d80008bf6766
😎 Deploy Preview https://deploy-preview-2217--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant

CLAassistant commented Nov 20, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sdirix

sdirix commented Nov 20, 2023

Copy link
Copy Markdown
Member

Thanks for the contribution ❤️

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 85.286% (+0.8%) from 84.469%
when pulling c33c50d on howdyAnkit:jasmine-desolate
into 77624c6 on eclipsesource:master.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@howdyAnkit

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing the PR brother ❤️

@sdirix
sdirix merged commit 4098f62 into eclipsesource:master Dec 12, 2023
@howdyAnkit
howdyAnkit deleted the jasmine-desolate branch December 12, 2023 14:46
@sdirix sdirix changed the title Fixes #1239 Add Angular Material Autocomplete test Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for filtering in autocomplete renderer

4 participants