Skip to content

feat: Implement GitHub Action for Publishing#2223

Merged
sdirix merged 3 commits into
eclipsesource:masterfrom
LukasBoll:publish_github_action
Dec 14, 2023
Merged

feat: Implement GitHub Action for Publishing#2223
sdirix merged 3 commits into
eclipsesource:masterfrom
LukasBoll:publish_github_action

Conversation

@LukasBoll

Copy link
Copy Markdown
Contributor

Introduce a GitHub Action to automate the publishing process for JSON Forms.
adjust dependencies with lerna
adjust peerdependencies with custom script

closes #2047

@netlify

netlify Bot commented Dec 4, 2023

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 1447886
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/657b00d12d541a00081c7db7
😎 Deploy Preview https://deploy-preview-2223--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls

coveralls commented Dec 4, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 83.078% (+0.05%) from 83.033%
when pulling 1447886 on LukasBoll:publish_github_action
into 18c0825 on eclipsesource:master.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments

Comment thread .github/workflows/publish.yaml Outdated
Comment thread .github/workflows/publish.yaml Outdated
Comment thread .github/workflows/publish.yaml Outdated
Comment thread .github/workflows/publish.yaml Outdated
Introduce a GitHub Action to automate the publishing process for
JSON Forms.
adjust dependencies with lerna
adjust peerdependencies with custom script
@LukasBoll
LukasBoll force-pushed the publish_github_action branch from 2581d1f to 712e256 Compare December 12, 2023 08:46

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add build and test steps, please check preparePublish script

@sdirix
sdirix marked this pull request as ready for review December 14, 2023 13:09
@sdirix
sdirix merged commit 1b517d6 into eclipsesource:master Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GH action for publish

3 participants