Disable vanilla array buttons when readonly#2303
Merged
lucas-koehler merged 5 commits intoSep 13, 2024
Merged
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sdirix
reviewed
Mar 18, 2024
sdirix
left a comment
sdirix
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution ❤️! Works for me!
Adapting the examples is great and allows to easily test the new functionality manually, thanks 👍!
Please also add a unit test so that the new behavior is safe from regressions.
lucas-koehler
force-pushed
the
disable-readonly-array-buttons
branch
from
September 12, 2024 10:31
6f4e0e4 to
ae31bad
Compare
Contributor
|
@sdirix @joefreeman I added tests that check that buttons are rendered with expected enabled and disabled state for enabled/disabled controls. |
sdirix
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the vanilla array controls (
TableArrayControlandArrayControlRenderer) to disable the buttons (for adding/removing/moving items) when the control is set to readonly (otherwise the data can be updated while readonly).To (manually) test this, I've updated the examples to support setting the
readonlyproperty of the<JsonForms>, and added toggle actions to a couple of the array examples. (Not sure if there's a better way to do this?)