Skip to content

Angular 18 Update#2340

Merged
sdirix merged 1 commit into
masterfrom
codeblock/feature/upgrade-angular-18
May 27, 2024
Merged

Angular 18 Update#2340
sdirix merged 1 commit into
masterfrom
codeblock/feature/upgrade-angular-18

Conversation

@lucas-koehler

@lucas-koehler lucas-koehler commented May 23, 2024

Copy link
Copy Markdown
Contributor

Based on PR #2337 extended by using the Angular 18 release and regenerated pnpm lock file by me.

@netlify

netlify Bot commented May 23, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 70e26f8
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6654825c19723f0008125b21
😎 Deploy Preview https://deploy-preview-2340--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler lucas-koehler mentioned this pull request May 23, 2024
Closed
@lucas-koehler

lucas-koehler commented May 23, 2024

Copy link
Copy Markdown
Contributor Author

@laurentgrangier Please confirm whether JsonForms works for you with Angular 18 in this state. If yes, we'll merge this and do a release soon.

@coveralls

coveralls commented May 23, 2024 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 83.322% (-0.03%) from 83.347%
when pulling 70e26f8 on codeblock/feature/upgrade-angular-18
into 5c5a470 on master.

sdirix
sdirix reviewed May 23, 2024
View reviewed changes

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the information about the angular upgrade in the migration document

@lucas-koehler

lucas-koehler commented May 23, 2024

Copy link
Copy Markdown
Contributor Author

@sdirix Good point! I added a Json Forms 3.3 section mentioning this to MIGRATION.md

@lucas-koehler lucas-koehler linked an issue May 23, 2024 that may be closed by this pull request
Add Angular 18 support #2336
Closed
@laurentgrangier

laurentgrangier commented May 27, 2024

Copy link
Copy Markdown
Contributor

@lucas-koehler Thank you for the new PR and the upgrade to Angular 18 final version. I check JsonForms with Angular 18 and give you feedback quickly (should be this week).

@laurentgrangier

laurentgrangier commented May 27, 2024

Copy link
Copy Markdown
Contributor

@lucas-koehler I tested JSONForms built on this branch with our software using Angular 17 and also using Angular 18 and had no problem with JSONForms. We only use jsonforms/core and jsonforms/angular. No other packages of jsonforms.

@sdirix
sdirix force-pushed the codeblock/feature/upgrade-angular-18 branch from 9563337 to 0bfd686 Compare May 27, 2024 12:53
@laurentgrangier @lucas-koehler @sdirix
feat: support Angular 18
70e26f8 
Updates code base to Angular 18. This removes support for Angular 16.

Also includes the following changes:

- removal of the angular test package
- Typescript update
- migration guide entry

Co-authored-by: Lucas Köhler <lkoehler@eclipsesource.com>
@sdirix
sdirix force-pushed the codeblock/feature/upgrade-angular-18 branch from 0bfd686 to 70e26f8 Compare May 27, 2024 12:53
@sdirix
sdirix merged commit 2f7e64c into master May 27, 2024
@sdirix
sdirix deleted the codeblock/feature/upgrade-angular-18 branch May 27, 2024 13:18
@sdirix

sdirix commented May 27, 2024

Copy link
Copy Markdown
Member

I also tested with React 18 in the Angular Seed application. That works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Angular 18 support

4 participants

@lucas-koehler @coveralls @laurentgrangier @sdirix